torchmetrics icon indicating copy to clipboard operation
torchmetrics copied to clipboard

fix macro when `ignore_index` is set

Open edumotya opened this issue 10 months ago • 4 comments

What does this PR do?

Fixes #1691

Additionally, tests have been updated to exclude the ignored class from the macro accuracy averaging.

Before submitting
  • [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


:books: Documentation preview :books:: https://torchmetrics--2163.org.readthedocs.build/en/2163/

edumotya avatar Oct 10 '23 19:10 edumotya

@edumotya how is it going, mind checking comment from Nicki

Borda avatar Nov 14 '23 17:11 Borda

@edumotya seems like most of the tests are off; could you pls check it... turning it back to draft until most other checks are green... pls make it as ready to review when you resolve them... :flamingo:

Borda avatar Jan 09 '24 12:01 Borda

sure @Borda, I am sorry for the late response. It might take me some time, it is not straightforward to fix the affected tests, I'll do my best

edumotya avatar Jan 11 '24 20:01 edumotya