torchmetrics icon indicating copy to clipboard operation
torchmetrics copied to clipboard

MAP: change bool to float32

Open dreaquil opened this issue 2 years ago • 3 comments

What does this PR do?

Fixes #1147

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

dreaquil avatar Jul 18 '22 13:07 dreaquil

hi @dreaquil, mind share motivation or what does it solves?

Borda avatar Jul 18 '22 14:07 Borda

Hi @Borda! This is to resolve this issue https://github.com/Lightning-AI/metrics/issues/1147. However, there is some missing test for this failure. I would like to add a test but I am unable to get my development environment set up for test discovery in Vscode.

Dealing with this issue:

ERROR  - ImportError: cannot import name 'metanet_pb2' from partially initial...

dreaquil avatar Jul 18 '22 14:07 dreaquil

Codecov Report

Merging #1150 (67a38da) into master (fbfe974) will decrease coverage by 51%. The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1150     +/-   ##
========================================
- Coverage      86%     34%    -51%     
========================================
  Files         195     195             
  Lines       11463   11463             
========================================
- Hits         9836    3935   -5901     
- Misses       1627    7528   +5901     

codecov[bot] avatar Jul 18 '22 16:07 codecov[bot]

Any update on this PR?

ashnair1 avatar Sep 13 '22 07:09 ashnair1