pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Fix advanced profiler for python >=3.12

Open relativityhd opened this issue 7 months ago • 1 comments

What does this PR do?

Fixes #19983

  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20809.org.readthedocs.build/en/20809/

relativityhd avatar May 10 '25 16:05 relativityhd

@relativityhd can we pls add a test for this case

Borda avatar May 19 '25 15:05 Borda

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 06:07 stale[bot]

@Borda Sorry, haven't seen your comment. To be honest, I don't know how this should be tested properly. There are no tests for it yet, and I don't have the time to create new ones. Best Tobias

relativityhd avatar Aug 01 '25 10:08 relativityhd

@bhimrazy mind have a look here, pls 🐿️

Borda avatar Aug 04 '25 13:08 Borda

@bhimrazy mind have a look here, pls 🐿️

Sure @Borda — thanks for the ping! I’ll take a look shortly. 🙌

bhimrazy avatar Aug 04 '25 16:08 bhimrazy

Hi @deependujha, could you pls check if you're able to add the changelog?

- Fixed `AdvancedProfiler` to handle nested profiling actions for Python 3.12+ ([#20809](https://github.com/Lightning-AI/pytorch-lightning/pull/20809))

I started getting a 403 error on my end.

bhimrazy avatar Aug 05 '25 08:08 bhimrazy