pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

fix: correct the positional encoding of Transformer in pytorch examples

Open Galaxy-Husky opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes #19138

Before submitting
  • [x] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [x] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20203.org.readthedocs.build/en/20203/

Galaxy-Husky avatar Aug 15 '24 09:08 Galaxy-Husky

Hi @Jay-Karia, I would like to work on this enhancement. Kindl assign it to me.

iamrishiksahu avatar Aug 01 '24 08:08 iamrishiksahu

@iamrishiksahu, there is no need to assign issues, you can just send a pull !

Jay-Karia avatar Aug 01 '24 09:08 Jay-Karia