pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

feat(integrations): Checkpoint logging flag `log_checkpoint_on` added to `WandbLogger`

Open ash0ts opened this issue 1 year ago • 1 comments

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [x] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19288.org.readthedocs.build/en/19288/

ash0ts avatar Jan 15 '24 18:01 ash0ts

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 28ae205bd99c38b962b6763011e11b088fbeb3f0 tests/tests_data/streaming/test_resolver.py View secret
- Generic High Entropy Secret 28ae205bd99c38b962b6763011e11b088fbeb3f0 tests/tests_data/streaming/test_resolver.py View secret
- Generic High Entropy Secret 28ae205bd99c38b962b6763011e11b088fbeb3f0 tests/tests_data/streaming/test_resolver.py View secret
- Generic High Entropy Secret 28ae205bd99c38b962b6763011e11b088fbeb3f0 tests/tests_data/streaming/test_resolver.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Jan 16 '24 09:01 gitguardian[bot]

@awaelchli Would love some 👀 on this

ash0ts avatar Feb 07 '24 14:02 ash0ts

Merged into #19297

ash0ts avatar Feb 12 '24 15:02 ash0ts