pytorch-lightning
pytorch-lightning copied to clipboard
Lightning-AI
bump: transmission to use `neptune` only, drop `neptune-client`
What does this PR do?
With the next feari=ure release let's cut and exclusively support neptune and drop legacy neptune-client, see: https://github.com/Lightning-AI/pytorch-lightning/pull/19131#discussion_r1428034943
Before submitting
- Was this discussed/agreed via a GitHub issue? (not for typos and docs)
- [x] Did you read the contributor guideline, Pull Request section?
- [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
- Did you make sure to update the documentation with your changes? (if necessary)
- Did you write any new necessary tests? (not for typos and docs)
- [x] Did you verify new and existing tests pass locally with your changes?
- Did you list all the breaking changes introduced by this pull request?
- Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)
PR review
Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
- [x] Is this pull request ready for review? (if not, please submit in draft mode)
- [x] Check that all items from Before submitting are resolved
- [x] Make sure the title is self-explanatory and the description concisely explains the PR
- [x] Add labels and milestones (and optionally projects) to the PR so it can be classified
📚 Documentation preview 📚: https://pytorch-lightning--19265.org.readthedocs.build/en/19265/
⚡ Required checks status: All passing 🟢
Groups summary
🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/neptune.py.
🟢 pytorch_lightning: Azure GPU
| Check ID | Status | |
|---|---|---|
| pytorch-lightning (GPUs) (testing Lightning | latest) | success | ✅ |
| pytorch-lightning (GPUs) (testing PyTorch | latest) | success | ✅ |
These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/neptune.py.
🟢 pytorch_lightning: Benchmarks
| Check ID | Status | |
|---|---|---|
| lightning.Benchmarks | success | ✅ |
These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/neptune.py.
🟢 pytorch_lightning: Docs
| Check ID | Status | |
|---|---|---|
| docs-make (pytorch, doctest) | success | ✅ |
| docs-make (pytorch, html) | success | ✅ |
These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py, requirements/pytorch/loggers.info.
🟢 pytorch_lightning: Docker
| Check ID | Status | |
|---|---|---|
| build-cuda (3.9, 1.13, 11.8.0) | success | ✅ |
| build-cuda (3.9, 1.13, 12.0.1) | success | ✅ |
| build-cuda (3.10, 2.0, 11.8.0) | success | ✅ |
| build-cuda (3.10, 2.1, 12.1.0) | success | ✅ |
| build-pl (3.9, 1.13, 11.8.0) | success | ✅ |
| build-pl (3.9, 1.13, 12.0.1) | success | ✅ |
| build-pl (3.10, 2.0, 11.8.0) | success | ✅ |
| build-pl (3.10, 2.1, 12.1.0) | success | ✅ |
These checks are required after the changes to requirements/pytorch/loggers.info.
🟢 mypy
| Check ID | Status | |
|---|---|---|
| mypy | success | ✅ |
These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/neptune.py.
🟢 install
These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py, requirements/pytorch/loggers.info.
Thank you for your contribution! 💜
Note This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact
carmoccafor help.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #19265 (b547287) into master (61ba180) will decrease coverage by
35%. Report is 1 commits behind head on master. The diff coverage is100%.
Additional details and impacted files
@@ Coverage Diff @@
## master #19265 +/- ##
==========================================
- Coverage 84% 48% -35%
==========================================
Files 450 442 -8
Lines 38105 37936 -169
==========================================
- Hits 31871 18378 -13493
- Misses 6234 19558 +13324
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Borda take a look a the response here from @SiddhantSadangi from the neptune team: https://github.com/Lightning-AI/pytorch-lightning/pull/18558#issuecomment-1721232187
@Borda take a look a the response here from @SiddhantSadangi from the neptune team: #18558 (comment)
Yes, the response was half a year ago, but still, if they support it, the API switch is for legacy Neptune-client, so the API in the new versions is the same I beilve we can cut Neptune-client<1.0
so with installing neptune==1.8.6 and asking import check
>>> import neptune
>>> from lightning_utilities.core.imports import RequirementCache
>>> RequirementCache("neptune>=1.0")
Requirement 'neptune>=1.0' met
then install the same neptune-client==1.8.6 and doing the same
>>> import neptune
>>> from lightning_utilities.core.imports import RequirementCache
>>> RequirementCache("neptune>=1.0")
DistributionNotFound: The 'neptune>=1.0' distribution was not found and is required by the application. HINT: Try running `pip install -U 'neptune>=1.0'`
>>> from lightning_utilities.core.imports import module_available
>>> module_available("neptune")
True
⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9f9a8b5247c95ae16d54fcb583c1668f9b | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9f9a8b5247c95ae16d54fcb583c1668f9b | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9f9a8b5247c95ae16d54fcb583c1668f9b | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9f9a8b5247c95ae16d54fcb583c1668f9b | tests/tests_data/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
![gitguardian[bot] avatar](https://avatars.githubusercontent.com/in/46505?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks @Borda for handling this :wink:. LGTM 🚀 . We should probably mention this PR here as well: https://github.com/Lightning-AI/pytorch-lightning/issues/18555 as it's not going to be fixed according to these PR. We're going to send some communication to our clients about the discontinuation of this support.
I'll rebase all my PRs soon after merge of this one :wink:.
We're going to send some communication to our clients about the discontinuation of this support.
sounds good; there is a long runway as this will be part of 2.3 so in a few months :runner: