pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Fix: filesystem edge case in `ModelCheckpoint`

Open schmidt-ai opened this issue 2 years ago • 4 comments

Fixes #17912.

schmidt-ai avatar Aug 07 '23 22:08 schmidt-ai

@awaelchli I could take a stab at adding a test case if you'd prefer? Though I may need a little additional detail on your idea for it!

schmidt-ai avatar Aug 23 '23 15:08 schmidt-ai

Codecov Report

Merging #18252 (8a760f2) into master (f52fedc) will decrease coverage by 35%. The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18252      +/-   ##
==========================================
- Coverage      84%      49%     -35%     
==========================================
  Files         439      431       -8     
  Lines       34484    34341     -143     
==========================================
- Hits        28877    16890   -11987     
- Misses       5607    17451   +11844     

codecov[bot] avatar Oct 12 '23 23:10 codecov[bot]

@schmidt-ai @awaelchli how is it going here? :)

Borda avatar Nov 18 '23 08:11 Borda

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Jan 16 '24 09:01 gitguardian[bot]