pytorch-lightning
pytorch-lightning copied to clipboard
Enable Intel xpu as a new backend of PyTorch-Lightning
What does this PR do?
Enable Intel xpu as a new backend of PyTorch-Lightning. Follow up PR of https://github.com/Lightning-AI/lightning/pull/16834
Contributed by [email protected] and [email protected].
Before submitting
- Was this discussed/agreed via a GitHub issue? (not for typos and docs)
- [ ] Did you read the contributor guideline, Pull Request section?
- [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
- Did you make sure to update the documentation with your changes? (if necessary)
- Did you write any new necessary tests? (not for typos and docs)
- [ ] Did you verify new and existing tests pass locally with your changes?
- Did you list all the breaking changes introduced by this pull request?
- Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)
PR review
Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from Before submitting are resolved
- [ ] Make sure the title is self-explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.
️✅ There are no secrets present in this pull request anymore.
If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@jingxu10 @abhilash1910 I just wanted to check what's the status on XPU integration with lightning. Is this effort still on the horizon or abandoned?
@jingxu10 @abhilash1910 I just wanted to check what's the status on XPU integration with lightning. Is this effort still on the horizon or abandoned?
Yes it is still in progress while we work out upstreaming Lightning -xpu module . Since there is a lot of demand , we are trying to expedite.
Do you have a beta of the Lightning-xpu module ? Google indicates some repo which does not exist anymore, internal to lightning-Ai only ?
Any progress on this? It would be great to see this implemented. Appreciate the effort!
Any progress on this? It would be great to see this implemented. Appreciate the effort!
Yes there is an ongoing discussion from Intel on this. Expecting further upstreaming effort soon.
It's already July, is there any progress on the courtesy inquiry? Pytorch 2.4 already natively supports XPU
It would be great to see this implemented soon. Can we temporarily merge the upstream changes into Intel's branch to provide a temporarily usable version? Appreciate the effort!