pytorch-lightning
pytorch-lightning copied to clipboard
[TPU] Install torch_xla in CUDA CI
What does this PR do?
Part of #16130
Sets up XLA testing on CUDA CI and other related pieces to get things working
- Add connector support for non-TPU
- Update existing
RunIf(tpu=...)tests and convert some toRunIf(xla=...)
XLA support for CUDA requires XLA nightly to work due to https://github.com/pytorch/xla/issues/4988
cc @carmocca @borda @JackCaoG @steventk-g @Liyang90 @justusschock @awaelchli
⛈️ Required checks status: Has failure 🔴
Warning This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask
Lightning-AI/lai-frameworksto re-run it. If you push a new commit, all of CI will re-trigger.
Groups summary
🔴 pytorch_lightning: Tests workflow
| Check ID | Status | |
|---|---|---|
| pl-cpu (macOS-11, lightning, 3.8, 1.11) | success | ✅ |
| pl-cpu (macOS-11, lightning, 3.9, 1.12) | success | ✅ |
| pl-cpu (macOS-11, lightning, 3.10, 1.13) | success | ✅ |
| pl-cpu (macOS-11, lightning, 3.10, 2.0) | success | ✅ |
| pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) | success | ✅ |
| pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) | success | ✅ |
| pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) | success | ✅ |
| pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) | success | ✅ |
| pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) | failure | ❌ |
| pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) | success | ✅ |
| pl-cpu (windows-2022, lightning, 3.8, 1.11) | success | ✅ |
| pl-cpu (windows-2022, lightning, 3.9, 1.12) | success | ✅ |
| pl-cpu (windows-2022, lightning, 3.10, 1.13) | success | ✅ |
| pl-cpu (windows-2022, lightning, 3.10, 2.0) | success | ✅ |
| pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) | success | ✅ |
| pl-cpu (macOS-11, pytorch, 3.8, 1.13) | success | ✅ |
| pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) | success | ✅ |
| pl-cpu (windows-2022, pytorch, 3.8, 1.13) | success | ✅ |
These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py, requirements/pytorch/strategies.txt, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/testing/_runif.py, tests/tests_pytorch/conftest.py.
🔴 pytorch_lightning: Azure GPU
| Check ID | Status | |
|---|---|---|
| pytorch-lightning (GPUs) | failure | ❌ |
These checks are required after the changes to .azure/gpu-tests-pytorch.yml, requirements/pytorch/strategies.txt, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/testing/_runif.py, tests/tests_pytorch/conftest.py, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py.
🟢 pytorch_lightning: Benchmarks
| Check ID | Status | |
|---|---|---|
| lightning.Benchmarks | success | ✅ |
These checks are required after the changes to requirements/pytorch/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/testing/_runif.py.
🟢 fabric: Docs
| Check ID | Status | |
|---|---|---|
| make-doctest (fabric) | success | ✅ |
| make-html (fabric) | success | ✅ |
These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py.
🟢 pytorch_lightning: Docs
| Check ID | Status | |
|---|---|---|
| make-doctest (pytorch) | success | ✅ |
| make-html (pytorch) | success | ✅ |
These checks are required after the changes to src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/testing/_runif.py, requirements/pytorch/strategies.txt.
🟢 pytorch_lightning: Docker
| Check ID | Status | |
|---|---|---|
| build-cuda (3.9, 1.11, 11.3.1) | success | ✅ |
| build-cuda (3.9, 1.12, 11.7.1) | success | ✅ |
| build-cuda (3.9, 1.13, 12.0.1) | success | ✅ |
| build-cuda (3.10, 2.0, 12.0.1) | success | ✅ |
| build-cuda (3.10, 2.0, 11.7.1) | success | ✅ |
| build-cuda (3.8, 2.0, 11.7.1) | success | ✅ |
| build-pl (3.9, 1.11, 11.3.1) | success | ✅ |
| build-pl (3.9, 1.12, 11.7.1) | success | ✅ |
| build-pl (3.9, 1.13, 12.0.1) | success | ✅ |
| build-pl (3.10, 2.0, 12.0.1) | success | ✅ |
These checks are required after the changes to .github/workflows/ci-dockers.yml, requirements/pytorch/strategies.txt.
🟢 lightning_fabric: CPU workflow
These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/conftest.py, tests/tests_fabric/strategies/test_dp.py, tests/tests_fabric/strategies/test_single_device.py.
🟢 lightning_fabric: Azure GPU
| Check ID | Status | |
|---|---|---|
| lightning-fabric (GPUs) | success | ✅ |
These checks are required after the changes to .azure/gpu-tests-fabric.yml, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/conftest.py, tests/tests_fabric/strategies/test_dp.py, tests/tests_fabric/strategies/test_single_device.py.
🟢 mypy
| Check ID | Status | |
|---|---|---|
| mypy | success | ✅ |
These checks are required after the changes to requirements/pytorch/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/testing/_runif.py.
🟢 install
These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/testing/_runif.py, requirements/pytorch/strategies.txt.
Thank you for your contribution! 💜
Note This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact
carmoccafor help.
This is blocked by https://github.com/pytorch/xla/issues/4988
⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 78fa3afdfbf964c19b4b2d36b91560698aa83178 | tests/tests_app/utilities/test_login.py | View secret |
| - | Base64 Basic Authentication | 78fa3afdfbf964c19b4b2d36b91560698aa83178 | tests/tests_app/utilities/test_login.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!