pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Published 20 hours ago • verified publisher icon Lightning-AI

refactor CLI to be top level package [wip]

Open Borda opened this issue 2 years ago • 4 comments

What does this PR do?

Moving the CLI to be top level package, as it is the mostly changed API point, so we can converge on App stability... discussed with @lantiga

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [x] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [x] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [x] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @borda @justusschock

Borda avatar Feb 23 '23 20:02 Borda

Duplicate of #24.

awebeer256 avatar Nov 12 '23 18:11 awebeer256

I was just looking into this as well :) I second this. I'd love to switch and the lack of Powerline support makes it less tempting.

livingstaccato avatar Nov 12 '23 18:11 livingstaccato

Duplicate of #24.

Powerline versions and nerd font versions are two different requests. Cascadia Code ships powerline only versions, for instance.

mthierman avatar Nov 19 '23 20:11 mthierman

For the zsh folks who use powerlevel10k, powerline fonts are required and nerd fonts are strongly recommended. See https://github.com/romkatv/powerlevel10k for the details. This is exactly my setup on Ubuntu and Debian.

znmeb avatar Nov 19 '23 20:11 znmeb

For the zsh folks who use powerlevel10k, powerline fonts are required and nerd fonts are strongly recommended. See https://github.com/romkatv/powerlevel10k for the details. This is exactly my setup on Ubuntu and Debian.

This is exactly why I opened the request for powerline fonts :) They are indeed the bare needed minimum for us zsh folks.

cdr-chakotay avatar Nov 20 '23 13:11 cdr-chakotay