pytorch-lightning
pytorch-lightning copied to clipboard
Enable quick-start-app-e2e
What does this PR do?
Fixes https://github.com/Lightning-AI/lightning/issues/14030
Added a new job for the quick-start as it requires more memory than the default e2e tests to install torch. Also it takes longer time to run the quick-start test so it has longer timeout.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
- [x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
- [x] Did you read the contributor guideline, Pull Request section?
- [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
- [x] Did you make sure to update the documentation with your changes? (if necessary)
- [x] Did you write any new necessary tests? (not for typos and docs)
- [x] Did you verify new and existing tests pass locally with your changes?
- [ ] Did you list all the breaking changes introduced by this pull request?
- [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)
PR review
Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
- [x] Is this pull request ready for review? (if not, please submit in draft mode)
- [x] Check that all items from Before submitting are resolved
- [x] Make sure the title is self-explanatory and the description concisely explains the PR
- [x] Add labels and milestones (and optionally projects) to the PR so it can be classified
Did you have fun?
Make sure you had fun coding 🙃
cc @borda
Codecov Report
Merging #14542 (43d0e59) into master (35419b5) will increase coverage by
1%
. The diff coverage is0%
.
:exclamation: Current head 43d0e59 differs from pull request most recent head 6809eeb. Consider uploading reports for the commit 6809eeb to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #14542 +/- ##
=========================================
+ Coverage 84% 85% +1%
=========================================
Files 395 328 -67
Lines 28801 25888 -2913
=========================================
- Hits 24125 21975 -2150
+ Misses 4676 3913 -763
@manskx @tchaton or @ethanwharris, mind checking the collision?
@manskx @tchaton or @ethanwharris, mind checking the collision?
everything is green now, seems it needs more reviews.