pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Add utility to use `HabanaDataLoader`

Open jerome-habana opened this issue 3 years ago • 1 comments

What does this PR do?

This PR adds support to exercise habana daloader through the PTL interfaces. The current supported dataset using habana dataloader is only Imagenet.

Reference

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • [ ] Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

jerome-habana avatar Aug 03 '22 02:08 jerome-habana

Codecov Report

Merging #13995 (16d4f03) into master (18e2a8e) will decrease coverage by 4%. The diff coverage is 25%.

:exclamation: Current head 16d4f03 differs from pull request most recent head db19c8e. Consider uploading reports for the commit db19c8e to get more accurate results

@@            Coverage Diff             @@
##           master   #13995      +/-   ##
==========================================
- Coverage      79%      76%      -4%     
==========================================
  Files         117      332     +215     
  Lines        7450    26747   +19297     
==========================================
+ Hits         5913    20241   +14328     
- Misses       1537     6506    +4969     

codecov[bot] avatar Aug 19 '22 10:08 codecov[bot]

Closing after our conversation. We agreed to continue this work in a repository owned by Habana, where we would link to their integrations in our docs and code if necessary.

carmocca avatar Nov 08 '22 16:11 carmocca