pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

[App] Add cloud platform exception

Open adam-lightning opened this issue 2 years ago • 0 comments

What does this PR do?

We add a new LightningPlatformException as to indicate possible error events happening on the platform the Lightning App is on. We currently consider (but future use is not limited to) the following cases:

  • User tries to create new default Work and exceeds the allowed quota (10).
  • User does not have enough credits and tries to create non-default Work.

This Exception is used on the launcher side, so here's just a definition of that exception.

This way if that's the user's intent, they can react accordingly to the situation.

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • [ ] Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [x] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @borda

adam-lightning avatar Jul 29 '22 13:07 adam-lightning