pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Remove incorrect "template" information

Open Felonious-Spellfire opened this issue 2 years ago • 0 comments

What does this PR do?

Removes incorrect information from documentation about creating apps and components from templates.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [X] Did you make sure to update the documentation with your changes? (if necessary)
  • [ ] Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @borda @rohitgr7

Felonious-Spellfire avatar Jul 28 '22 15:07 Felonious-Spellfire

Removes incorrect information from documentation about creating apps and components from templates.

@Felonious-Spellfire why this is "incorrect information" ?

manskx avatar Aug 17 '22 14:08 manskx

Removes incorrect information from documentation about creating apps and components from templates.

@Felonious-Spellfire why this is "incorrect information" ?

This came up in a Slack conversation. I was told to remove the content because it was incorrect and that users should use Lightning Apps as templates

Felonious-Spellfire avatar Aug 17 '22 17:08 Felonious-Spellfire