pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Fix mypy errors attributed to `pytorch_lightning.trainer.connectors.data_connector.py`

Open jxtngx opened this issue 2 years ago • 2 comments

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.trainer.connectors.data_connector.py for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [x] Did you make sure to update the documentation with your changes? (if necessary)
  • [x] Did you write any new necessary tests? (not for typos and docs)
  • [x] Did you verify new and existing tests pass locally with your changes?
  • [x] Did you list all the breaking changes introduced by this pull request?
  • [x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [x] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [x] Add labels and milestones (and optionally projects) to the PR so it can be classified

jxtngx avatar Jul 23 '22 11:07 jxtngx

Codecov Report

Merging #13806 (ec1702e) into master (70fe0ed) will decrease coverage by 3%. The diff coverage is 100%.

:exclamation: Current head ec1702e differs from pull request most recent head 8fa58a8. Consider uploading reports for the commit 8fa58a8 to get more accurate results

@@            Coverage Diff             @@
##           master   #13806      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         111      332     +221     
  Lines        7258    26897   +19639     
==========================================
+ Hits         5740    20435   +14695     
- Misses       1518     6462    +4944     

codecov[bot] avatar Jul 28 '22 02:07 codecov[bot]

messed up somewhere :p will check tomorrow!

rohitgr7 avatar Aug 09 '22 21:08 rohitgr7

apologies, I'm no longer able to keep this PR up to date.

jxtngx avatar Aug 16 '22 15:08 jxtngx

@JustinGoheen, we're sorry to hear that. @rohitgr7, are you gonna push it over the finish line or should I? I noticed you started pushing some commits :zap:

otaj avatar Aug 17 '22 06:08 otaj

@otaj it's done. Any things else needs to be done here? The CI is blocking the merge for now

rohitgr7 avatar Aug 17 '22 08:08 rohitgr7

@rohitgr7, awesome, thank you! :tada:. I guess we just have to wait on codeowners and CI

otaj avatar Aug 17 '22 09:08 otaj