pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Fix mypy errors attributed to `pytorch_lightning.core.module.py`

Open jxtngx opened this issue 2 years ago • 2 comments

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.core.module.py for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [x] Did you make sure to update the documentation with your changes? (if necessary)
  • [x] Did you write any new necessary tests? (not for typos and docs)
  • [x] Did you verify new and existing tests pass locally with your changes?
  • [x] Did you list all the breaking changes introduced by this pull request?
  • [x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [x] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [x] Add labels and milestones (and optionally projects) to the PR so it can be classified

jxtngx avatar Jul 11 '22 16:07 jxtngx

Original errors after removing module from pyproject.toml can be viewed at: https://github.com/JustinGoheen/lightning/blob/lightningmodule/code-quality/type-hints/module_typehint_errors.md

jxtngx avatar Jul 11 '22 16:07 jxtngx

Codecov Report

Merging #13603 (c1bf538) into master (7879628) will decrease coverage by 10%. The diff coverage is 93%.

@@            Coverage Diff            @@
##           master   #13603     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         330      330             
  Lines       26773    26809     +36     
=========================================
- Hits        22993    20385   -2608     
- Misses       3780     6424   +2644     

codecov[bot] avatar Aug 02 '22 15:08 codecov[bot]

apologies, I'm no longer able to keep this PR up to date.

jxtngx avatar Aug 16 '22 15:08 jxtngx

apologies, I'm no longer able to keep this PR up to date.

No worries, I will address reviews and finish it. There shouldn't be too much work left here. @rohitgr7 @carmocca

awaelchli avatar Aug 18 '22 14:08 awaelchli