litgpt icon indicating copy to clipboard operation
litgpt copied to clipboard

Deal with warnings during model download and conversion

Open Andrei-Aksionov opened this issue 1 year ago • 3 comments

When we download (and automatically convert) a model, we have these three warnings:

  1. .../huggingface_hub/file_download.py:1132: FutureWarning: resume_download is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use force_download=True.
  2. .../huggingface_hub/file_download.py:1194: UserWarning: local_dir_use_symlinks parameter is deprecated and will be ignored. The process to download files to a local folder has been updated and do not rely on symlinks anymore. You only need to pass a destination folder aslocal_dir. For more details, check out https://huggingface.co/docs/huggingface_hub/main/en/guides/download#download-files-to-local-folder.
  3. [W init.cpp:1436] Warning: write_record(): Passing Storage by data pointer is deprecated and will be an error in the future, please pass the Storage object instead. (function operator())

First two come during weights downloading, while the third - during conversion.

Andrei-Aksionov avatar Jul 06 '24 16:07 Andrei-Aksionov

Good call. I can take care of these next week

rasbt avatar Jul 07 '24 12:07 rasbt

It's not super-urgent, so maybe let's give the community a chance. I think it's a cool thing when there are a number of good first issue issues, so it's easier to start contributing. Other issues are quite technical, and it might be overwhelming for someone. I started contributing by just providing annotations 😉.

Andrei-Aksionov avatar Jul 07 '24 12:07 Andrei-Aksionov

Good point, I agree

rasbt avatar Jul 07 '24 13:07 rasbt

This Issue has been solved, I think we can close it.

bhargavyagnik avatar Jul 15 '24 13:07 bhargavyagnik

Good point. Thanks again for the contribution!

rasbt avatar Jul 15 '24 13:07 rasbt

Anytime! I would love to contribute more and will keep an eye on the issues page for more contributions! If you have any, let me know. Thanks

bhargavyagnik avatar Jul 15 '24 14:07 bhargavyagnik