litgpt icon indicating copy to clipboard operation
litgpt copied to clipboard

Categorize SFT and Pretraining data

Open rasbt opened this issue 1 year ago • 2 comments

Ideally we only want the SFT finetuning datasets to show up in litgpt finetune --help and only the pretraining datasets to show up in litgpt pretrain --help.

I believe we were thinking about that a while back but there was no good way to do that with jsonargparse. I am opening this issue so we don't forget to revisit this someday.

rasbt avatar Apr 03 '24 21:04 rasbt

Isn't this a duplicate of https://github.com/Lightning-AI/litgpt/issues/1084 of yours?

carmocca avatar Apr 04 '24 15:04 carmocca

Note that this needs to be done by having two different base classes and having the files use only one of them in their type signatures

carmocca avatar Apr 04 '24 15:04 carmocca

We can close this as duplicate.

rasbt avatar Apr 18 '24 19:04 rasbt