litdata icon indicating copy to clipboard operation
litdata copied to clipboard

CONTRIBUTING.md for LitData

Open deependujha opened this issue 1 year ago • 2 comments

What does this PR do?

Fixes #354

I've just copy-pasted CONTRIBUTING.md from pytorch-lightning repository. No modifications done yet. Let's Work together on this and adapt it for LitData.

Aim is to make it simple and powerful enough for beginners to get started with contributing to LitData.

cc: @bhimrazy

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

deependujha avatar Oct 08 '24 06:10 deependujha

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (7264fce) to head (d01c87b). Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #391   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5044   5042    -2     
===================================
  Hits       3948   3948           
+ Misses     1096   1094    -2     

codecov[bot] avatar Oct 08 '24 06:10 codecov[bot]

Let's Work together on this and adapt it for LitData.

Sure @deependujha. Thanks for drafting a PR.

bhimrazy avatar Oct 08 '24 08:10 bhimrazy

chunk deletion issue is back, but this time on Windows. 😵‍💫 I'll inspect the bug later on.

For now, this PR is ready for review.

deependujha avatar Oct 14 '24 15:10 deependujha

It seems that this PR also includes some changes in data_processor.py, but that's fine.

The original PR was merged before I could remove the loop (I was not active).

deependujha avatar Oct 14 '24 16:10 deependujha

Nice @deependujha !

tchaton avatar Oct 15 '24 07:10 tchaton