lightning-thunder
lightning-thunder copied to clipboard
Lightning-AI
Implement clone()
Fixes #342.
- [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
- [x] Did you read the contributor guideline, Pull Request section?
- [x] Did you make sure to update the docs?
- [x] Did you write any new necessary tests?
What does this PR do?
Fixes #342
PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Always ;-)
The failures are distributed notebook flakiness; unrelated, so marking ready for review.
I didn't understand the #342 comment about not making this a symbol. Without the @torchsymbol decorator, clone calls won't map to this implementation, of course. Maybe someone could help educate me on how else this could be done?
The test failures are for distributed things: https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=202766&view=logs&j=b97dbf6d-98bd-5b68-7c01-878b39c3da28&t=3c72ede2-92c1-5cd2-2bac-ad2411af2aea&l=306 which seem unrelated. Let's try merging main into this...
triage review — just return a for the impl seems OK for now — we can follow-up if that confuses practitioners or we want more clarity
The failures are just the distributed tests failing, issue #432. This is ready for re-review / merging.