lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

Published 20 hours ago • verified publisher icon Lightning-AI

add TensorBase.is_complex

Open khushi-411 opened this issue 1 year ago • 1 comments

Before submitting
  • [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure to update the docs?
  • [x] Did you write any new necessary tests?

What does this PR do?

Fixes #339

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Sure thing!!!

khushi-411 avatar May 08 '24 17:05 khushi-411

Hey @khushi-411! I made some comments about how to add this as a non-symbol function and method. Let's see how that works! We haven't done a lot of that before, and other operators would benefit from a pattern for it, too

mruberry avatar May 09 '24 14:05 mruberry

Hey @khushi-411 let us know if you need help!

lantiga avatar Jun 03 '24 12:06 lantiga

Picking this up since a month has passed without updates #644

riccardofelluga avatar Jun 25 '24 08:06 riccardofelluga

Picking this up since a month has passed without updates #644

Hi, @riccardofelluga! If you would like to take over the issue and work on it, please feel free to do so. I appreciate your understanding and assure you that I'll update the PRs quickly in the future. I apologize for the delay. Thank you!

khushi-411 avatar Jun 25 '24 10:06 khushi-411