lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

bumps cudnnex to 1.2.1 (PR2485)

Open vedaanta opened this issue 11 months ago • 1 comments

What does this PR do?

Bumps cudnn FE version to 1.2.1

vedaanta avatar Mar 21 '24 17:03 vedaanta

just rerun the GPU test in about an hour when the new dockers are updates :flamingo:

Borda avatar Mar 22 '24 14:03 Borda

Great to see the upgrade, Vedaanta! Let me know if you wrote this down somewhere: What does 1.2.1 bring to Thunder? For example, does it fix some disabled tests here?

wujingyue avatar Mar 27 '24 20:03 wujingyue

https://github.com/NVIDIA/cudnn-frontend/releases/tag/v1.2.1 1.2.1 was done to fix the way FE finds cudnn_backend(BE) as compared to torch.

On larger note, there is a push going on right now to publish FE on pypi. This required quite a few changes to FE internally. One such change was the dlopen order of BE libs. 1.2.0 broke with thunder CI. more info on this slack thread Now with the new order of dlopen in 1.2.1, FE integration seems better.

vedaanta avatar Mar 27 '24 20:03 vedaanta