lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

Published 20 hours ago • verified publisher icon Lightning-AI

Implement TensorBase.div_

Open athitten opened this issue 1 year ago • 1 comments

🚀 Feature

Implement TensorBase.div_

Motivation

NeMo's MegatronNeVaModel

cc @tfogal

athitten avatar May 01 '24 18:05 athitten

Hi Team! While .div_ is a in-place version of .div, would it be acceptable to add TensorBase.div for this issue?

k223kim avatar May 17 '24 02:05 k223kim

Hey Kaeun, sorry for the slow reply on this one! Must have slipped through.

We'd love to have you tackle TensorBase.div---thank you so much! Let's just make sure we leave this issue open after the div operator gets committed (as this would still require some effort to deal with inplace even after #441 makes it in). Thanks!

tfogal avatar May 24 '24 23:05 tfogal

98% sure Masaki's recent PR implemented this.

Assigning to Masaki to either close or comment on status.

tfogal avatar Jun 27 '24 00:06 tfogal