lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

Some tests in test_dynamo.py are taking more than a minute

Open t-vi opened this issue 7 months ago • 3 comments

On the GPU main, these are > 1 minute:

161.42s call     thunder/tests/test_dynamo.py::test_thunder_specific_reports
137.88s call     thunder/tests/test_dynamo.py::test_report_thunderfx_pytest_benchmark_report
113.29s call     thunder/tests/test_dynamo.py::test_reports_repro
66.82s call     thunder/tests/test_dynamo.py::test_ThunderCompilerGraphBenchmarking_groupby
64.19s call     thunder/tests/test_dynamo.py::test_dynamo_reproducer_split_DynamoThunder_cuda_None[benchmark]
63.42s call     thunder/tests/test_dynamo.py::test_reports_benchmark

cc @borda

t-vi avatar May 08 '25 17:05 t-vi

@kiya00, what's happening in these tests? Is it the parameterization of different parameters, or are the tested tools relatively slow?

IvanYashchuk avatar May 09 '25 07:05 IvanYashchuk

Removed thunderfx label because it's unrelated to ThunderFX. It's about the error reproducibility and the benchmarking script generation Yan was working on.

IvanYashchuk avatar May 09 '25 07:05 IvanYashchuk

It's just this slow to test it, for example, test_thunder_specific_reports, it tests on the function that has dynamo break and thunder split, which results in 4 subgraphs, and for each graph there are 3 backends, and each repro script is saved and test for runnability, I can simplify it by just test one case. Is the requirement to keep the execution time of each test case under 1 minute?

kiya00 avatar May 12 '25 14:05 kiya00