lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

Re-enable inductor tests on windows

Open tfogal opened this issue 1 year ago • 2 comments

We had to disable a couple tests on windows because they now fail on windows:

FAILED thunder/tests/test_torch_compile_executor.py::test_torch_compile_litgpt - torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised:
RuntimeError: Compiler: cl is not found.

FAILED thunder/tests/test_autocast.py::test_torch_compile_autocast - 
torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised:
RuntimeError: Compiler: cl is not found.

🐛 Bug

Re-enable the tests.

To Reproduce

Just drop the or platform.system() == Windows in the existing skipIf clause on these two tests.

Additional context

Example CI run where this failed: https://github.com/Lightning-AI/lightning-thunder/actions/runs/11390861866/job/31693384602?pr=1324

cc @borda

tfogal avatar Oct 17 '24 22:10 tfogal

I think the main thing is to get the environment set up "vcvarsall.bat", unfortunately, it seems a bit of a hassle.

t-vi avatar Oct 18 '24 19:10 t-vi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '25 06:04 stale[bot]