lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

Reduce siginfo in traces to optional

Open t-vi opened this issue 1 year ago • 1 comments

There currently is a lot of overlap with args and it's a bit annoying to have to care about siginfo whenever constructing an intermediate trace. So maybe it would be good to use siginfo only for the gaps to trace.args and trace.kwargs to not need to append siginfo for intermediate traces we produce.

cc @carmocca @borda

t-vi avatar Oct 01 '24 20:10 t-vi

So this could be automated:

https://github.com/Lightning-AI/lightning-thunder/blob/10a8a449109a2f33caa722b9cff2d588c8eb1954/thunder/core/jit_ext.py#L644-L652

t-vi avatar Oct 01 '24 21:10 t-vi