lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

Error on reentrant jit invocation

Open t-vi opened this issue 1 year ago • 5 comments

...to provide a better error message. Most likely the easiest is to add something like

    if get_jit_ctx() is not None:
        raise NotImplementedError("Re-entrant jitting is not supported")

to the top of thunder.jit.thunder_general_jit and then write a test.

First step in #1126

cc @carmocca @borda

t-vi avatar Sep 30 '24 19:09 t-vi

Hello @t-vi - We were wondering if we could pick this issue. Just wanted to know if there are any details that might help us to get started.

Nachiket18 avatar Oct 13 '24 01:10 Nachiket18

Hello @t-vi - I wanted to reach out to see if this issue can be picked by us to resolve.

Nachiket18 avatar Oct 17 '24 18:10 Nachiket18

Sure thing.

t-vi avatar Oct 17 '24 18:10 t-vi

Thanks. @UltraArceus3 @Dev-10sky and I will start working on the change.

So we will add the Error Message on this line - https://github.com/Lightning-AI/lightning-thunder/blob/main/thunder/core/jit_ext.py#L1664

Which test file should we refer to test this change? I'm trying to understand how the test case would look like.

Nachiket18 avatar Oct 19 '24 22:10 Nachiket18

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '25 06:04 stale[bot]

Thanks. @UltraArceus3 @Dev-10sky and I will start working on the change.

@Nachiket18 are you still considering working on this issue?

Borda avatar Jun 10 '25 14:06 Borda

I am interested in this issue if it is open for contribution!

fnhirwa avatar Jul 09 '25 11:07 fnhirwa