remove jit(fsdp(model)) codepath

[t-vi]

The old codepath is not composable with other transforms, does not offer gathering of state dicts as easily etc.

Removing, of course depends on NVIDIA benchmarking not needing it. I think we (@crcrpar actually) switched a couple of months ago or so.

@mpatel31415 @tfogal @crcrpar @IvanYashchuk wdyt?

[nvMelissa]

Brought up in triage review. Assigned to Tom V.

[crcrpar]

I'd say the removal should be after https://github.com/Lightning-AI/lightning-thunder/issues/1051 is fixed.

[t-vi]

@crcrpar Thank you for pointing that out!

So what kind of delay should we have to be sure the benchmarking works without it?

[mpatel31415]

We already use the new node, which contains: distributed_first := (self.compile in ("eager", "inductor") or "dynamo" in self.compile):

so from Mixology perspective it should be fine.

[crcrpar]

Just to clarify my take then, I was just conservative as I wasn't super confident if the constraint written in the issue linked in my previous comment would be fixed clearly.

[t-vi]

@crcrpar @mpatel31415 So with a few more weeks, are we more confident?