ecosystem-ci icon indicating copy to clipboard operation
ecosystem-ci copied to clipboard

Add NNI's CI

Open ultmaster opened this issue 3 years ago • 4 comments

Before submitting

  • [x] Was this discussed/approved via a GitHub issue? microsoft/nni#4504
  • [x] Did you create/update your configuration file?
  • [x] Did you add your config to CI - GitHub action and Azure pipeline?
  • [ ] Are all integration tests passing? - how should I test it?

What does this PR do? [optional]

Integrate NNI's test into lightning, so that we are aware of the upstream changes. Thanks Lightning team for your support! Resolves https://github.com/microsoft/nni/issues/4504

Did you have fun?

Make sure you had fun coding 🙃

ultmaster avatar Jan 27 '22 02:01 ultmaster

Codecov Report

Merging #32 (5539cd8) into main (400ad67) will decrease coverage by 0%. The diff coverage is 91%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #32   +/-   ##
==================================
- Coverage    85%   85%   -0%     
==================================
  Files         2     2           
  Lines       230   234    +4     
==================================
+ Hits        196   199    +3     
- Misses       34    35    +1     

codecov[bot] avatar Jan 27 '22 08:01 codecov[bot]

Hi @Borda , looks like my work is done here.

For rest of the tests, building dockers lacks credential, and I'm not sure whether codecov is a necessary condition. You might want to double-check the changes I've made to assistant.py, and maybe reshape them to be whatever you want.

Unfortunately, NNI doesn't work with pytorch-lightning on the master branch (5 tests failed). I'll ask my colleagues to look at it. As it's approaching Lunar's new year in China and people are on vacation, I don't expect that it can be quickly solved. Let's pin it to lightning v1.5.x for now.

ultmaster avatar Jan 27 '22 16:01 ultmaster

Hi @Borda , I'm writing to check the status of this pull request. What's the status here? Are there any blocking issues? Anything I can help?

ultmaster avatar Feb 25 '22 15:02 ultmaster

What's the status here? Are there any blocking issues? Anything I can help?

yep, sorry, was busy somewhere else, but hopefully get to it soon

Borda avatar Feb 25 '22 17:02 Borda