deep-learning-project-template icon indicating copy to clipboard operation
deep-learning-project-template copied to clipboard

Published 20 hours ago • verified publisher icon Lightning-AI

CI continously failing

Open pierresegonne opened this issue 4 years ago • 1 comments

Problem

The template test test_classifier.py does not pass when triggered as a GitHub action.

The issue comes from imports. Indeed the import from project.datasets.mnist import mnist is erroneous. There is no datasets folder in project because datasets is ignored (see l.37 of .gitignore).

Pulling the MNIST dataset everytime the GitHub action is triggered does not seem reasonable. My proposal would be to have a samples_datasets/ subfolder in test, not ignored, with a limited number of data points, and to use that for testing.

If anyone agree that it's a reasonable way to go, I'll create a PR :)

pierresegonne avatar Oct 22 '20 14:10 pierresegonne

yes, some files are missing, probably @williamFalcon has them locally,,,

Borda avatar Apr 05 '21 18:04 Borda