LitServe icon indicating copy to clipboard operation
LitServe copied to clipboard

Feat/evict req on client disconnect streaming case

Open bhimrazy opened this issue 1 year ago • 3 comments

Before submitting
  • [x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure to update the docs?
  • [x] Did you write any new necessary tests?

How does this PR impact the user?

As a user, I want the server to stop processing requests that disconnect from the client before finishing. This PR focuses on tracking disconnected requests (specifically for non-batched streaming mode) and stops those running tasks, saving resources and freeing up space for handling other requests.

What does this PR do?

Partially fixes #165.

  • Handles client request disconnection in streaming mode (non-batch).

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

bhimrazy avatar Aug 26 '24 16:08 bhimrazy

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95%. Comparing base (44e0fe9) to head (49bed55). Report is 114 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #223   +/-   ##
===================================
- Coverage    95%    95%   -0%     
===================================
  Files        18     18           
  Lines      1173   1185   +12     
===================================
+ Hits       1112   1122   +10     
- Misses       61     63    +2     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 26 '24 16:08 codecov[bot]

Hi @aniketmaurya,

I’ve made some modifications to check at specific intervals rather than on each output, hoping this approach might minimize any impact.

However, if this PR is affecting performance, I’m more than willing to close it. We can then explore alternative solutions that might be more effective.

bhimrazy avatar Sep 01 '24 17:09 bhimrazy

Hey @bhimrazy thanks for the patience, we're going to benchmark soon!

lantiga avatar Sep 10 '24 20:09 lantiga

Hi @bhimrazy, closing this PR for now. At this point, feel free to reopen or create a new PR when you get back to this.

aniketmaurya avatar Mar 11 '25 17:03 aniketmaurya