LightTable icon indicating copy to clipboard operation
LightTable copied to clipboard

Remove set-width-final! see #2038

Open geusebi opened this issue 9 years ago • 5 comments

This fix seems to solve #2038 but I actually don't know why or how it looks to fix it :) It needs testing before being considered for a merge.

geusebi avatar Feb 22 '16 12:02 geusebi

This fix seems to address the issue and I have not found any problems introduced by removing the code.

@cldwalker, @rundis - any interest in testing this out as well, or are we clear to merge?

sbauer322 avatar Oct 18 '16 02:10 sbauer322

@sbauer322 Before removing a behavior as a fix, it'd be good to dig in and understand what the behavior is providing and for what cases it works and doesn't work (I haven't written this and don't have context). If we are unable to fix it, we should determine if removing it from the codebase will have a negative effect on some users. If it will, then an alternative could be to have not it enabled by default e.g. removing https://github.com/LightTable/LightTable/blob/acf9514f022b61ee2147416e40e81e45ce3f9454/deploy/settings/default/default.behaviors#L556. Kenny digged into this some at https://github.com/LightTable/LightTable/issues/2038#issuecomment-157209962

cldwalker avatar Oct 18 '16 12:10 cldwalker

we should determine if removing it from the codebase will have a negative effect on some users

@cldwalker - could you elaborate on how we would go about testing this with users?

sbauer322 avatar Nov 03 '16 02:11 sbauer322

@cldwalker - could you elaborate on how we would go about testing this with users?

I'm not suggesting testing this w/ users but rather confirming that this works locally for the different scenarios mentioned in #2038 - different # of monitors and possibly on different platforms

cldwalker avatar Nov 12 '16 19:11 cldwalker

Thanks for clarifying!

sbauer322 avatar Nov 12 '16 21:11 sbauer322