2FA icon indicating copy to clipboard operation
2FA copied to clipboard

Forever authenticated

Open jfk9w opened this issue 3 years ago • 2 comments

Describe the bug

  1. It looks like 2FA does not expire until server restart (or takes very long to expire).
  2. Also you can still open doors (and maybe use some activated items, I haven't checked) when not authenticated.

How To Reproduce

  1. Start the server with 2FA.
  2. Authenticate.
  3. Log out.
  4. Log in again. You will not be prompted anything from 2FA plugin. "require-when.on-ip-change" and "require-when.every-login" configuration properties are ignored.

Expected behavior Player authentication should expire on quit.

Server Information Server Java and OS

  • Java Runtime Version: 17.0.5+8
  • OS: Linux

Server Plugins

  • LuckPerms | 5.4.54 | Enabled: true
  • PrometheusExporter | 2.5.0 | Enabled: true
  • 2FA | 1.6.3 | Enabled: true

Server Jar, Versions and Information

  • Spigot Build version: git-Paper-307 (MC: 1.19.2)
  • Server Version: 1.19.2-R0.1-SNAPSHOT
  • Version Instance: v1_19_2
  • NMSVersion Instance: v1_19_R1
  • Max Memory: 4294 MB
  • Free Memory: 2247 MB
  • Total Memory: 4294 MB

Communication Method & Proxies:

  • Using Bungeecord: false
  • Is Proxy Loaded: false
  • Communication Method in config: NONE
  • Communication Timeout in config: 30 ticks

Storage Information:

  • Type of Storage: JSON
  • Is external Storage loaded: false

Additional context It looks like onPlayerQuit is not called for some reason.

jfk9w avatar Dec 10 '22 16:12 jfk9w

Same issue over here

LoneDevilX avatar Dec 19 '22 11:12 LoneDevilX

Issue is still here

StKillReal avatar Jul 25 '23 03:07 StKillReal

This issue shouldn't be happening on 1.7.0, if the issue still happens, I'll reopen this github issue

DirtyConcept avatar Jul 06 '24 12:07 DirtyConcept