libvisual icon indicating copy to clipboard operation
libvisual copied to clipboard

Published 20 hours ago • verified publisher icon Libvisual

Core (Tests): Add unit test for image loading

Open kaixiong opened this issue 2 years ago • 4 comments

kaixiong avatar Feb 06 '23 15:02 kaixiong

@kaixiong update: I figured now that that's what pull requests #259 is fixing. Let's merge #259 then and rebase #258 onto latest master and then CI should be all green with some luck.

hartwork avatar Feb 06 '23 18:02 hartwork

PS: I have canceled the related CI runs for now so that runners can pick up other jobs again.

hartwork avatar Feb 06 '23 19:02 hartwork

@hartwork, it's fixed!

There are still tests for 8-bit and 16-bit images to come. Once this PR is completed and merged, the functions developed here will be used to validate the PNG save function (#206) by means of round-tripping.

kaixiong avatar Feb 07 '23 16:02 kaixiong

@hartwork, it's fixed!

@kaixiong it's rebased on 7d536d1e74e0e28b9d0f4c9194672bc49f8a921d by now, I see. Nice, I won't cancel it again then, good to know! :smile:

There are still tests for 8-bit and 16-bit images to come. Once this PR is completed and merged, the functions developed here will be used to validate the PNG save function (#206) by means of round-tripping.

Sounds good! :+1:

hartwork avatar Feb 07 '23 16:02 hartwork