Revive icon indicating copy to clipboard operation
Revive copied to clipboard

Incomplete rendering in Condor Soaring Simulator

Open Gu7 opened this issue 4 years ago • 13 comments

Do not report issues when using the Virtual Desktop or ALVR drivers for SteamVR, this is not supported by Revive.

Describe the bug Canopy, instruments and sky areas are rendered as black.

To Reproduce Steps to reproduce the behaviour:

  1. It is assumed Condor 2 is already installed and configured for VR (appreciate you're not going to rush out and buy it, I'm more than happy to help with testing in any way I can).
  2. Install Revive (currently running beta 2.1.1.131)
  3. Launch Revive
  4. Right click Revive tray icon
  5. Select "Inject"
  6. Browse to Condor.exe and double click
  7. Prepare flight in Condor and start flight
  8. Once flight starts observe that canopy, instruments and sky are black / opaque. See attached screenshots of Revive/ pancake comparisons.

Expected behavior Sky, canopy and instruments should render using Revive as they do in pancake mode.

Environment (please complete the following information):

  • App: Condor 2 Soaring Simulator
  • OS: Win 10 64 Pro 19042
  • Headset: HP Reverb G2

Versions (please complete the following information):

  • Revive: beta 2.1.1.131
  • SteamVR: 1.15.19 (1610416788) NOTE: Steam VR not running. If I do try to run it, Steam VR stops on opening the flight in VR.

Create a system report Happy to send sys report "off list" if required.

Additional context Have tried OpenVR on and off. Results are same. Have tried with xinput/x64/xinput_1_3.dll, LibRevive64.dll, openvr_api64.dll in Condor2 program folder and without. Results are the same. Happy to try testing and feed back / help in any way.

PancakeExternal ReviveExternal PancakeInCockpit ReviveInCockpit

Gu7 avatar Feb 05 '21 20:02 Gu7

Can you try the beta version of Revive? Link is on the main page.

CrossVR avatar Feb 05 '21 22:02 CrossVR

I'm currently using the version at https://ci.appveyor.com/project/librevr/revive/build/artifacts

To be sure all is clean, I uninstalled and reinstalled.

Repeated the checks and the results are the same.

Other observations (no idea whether useful though):

  • Even these results is a huge step forward as up until now only Revive pre- version 2 builds will run Condor in VR. Revive 2.1.1.131 is so tantalisingly close!
  • Condor 2 is 32-bit
  • No files have to be placed in to the Condor installation when using Revive 2.1.1.131, inject works fine.
  • I am able to set MSAA in Condor with Revive 2.1.1.131 and get the results we see here (results are the same whether MSAA is enabled or not). ** Revive version 1.9.1 for example will render everything in black except the pop up text like "RACE IN:..." if any MSAA is used. ** Revive version 1.9.1 renders everything correctly if MSAA is not used.

Gu7 avatar Feb 07 '21 12:02 Gu7

Do you get the same results in 1.9.2 as you do in 1.9.1?

CrossVR avatar Feb 07 '21 17:02 CrossVR

Results for 1.9.1 and 1.9.2 are identical:

Revive 1.9.2 MSAA disabled in game:

  • Right click Revive tray icon
  • Inject Condor.exe...
  • Condor menu starts
  • Start flight...
  • Steam VR does not stop running
  • everything renders fine in VR Revive1 9 1_MSAA-off_VR-View

MSAA enabled in game:

  • Right click Revive tray icon
  • Inject Condor.exe...
  • Condor menu starts
  • Start flight...
  • Steam VR does not stop running
  • All renders in VR as blank except the "info text" Revive1 9 2_MSAA-on_VR-View

Revive 1.9.1 MSAA disabled in game:

  • Right click Revive tray icon
  • Inject Condor.exe...
  • Condor menu starts
  • Start flight...
  • Steam VR does not stop running
  • everything renders fine in VR See Revive1.9.x_MSAA-off_VR-View above

MSAA enabled in game:

  • Right click Revive tray icon
  • Inject Condor.exe...
  • Condor menu starts
  • Start flight...
  • Steam VR does not stop running
  • All renders in VR as blank except the "info text" See Revive1.9.x_MSAA-on_VR-View above

For comparison in the same format as above: Revive 2.1.1.131 beta MSAA disabled in game:

  • Right click Revive tray icon
  • Inject Condor.exe...
  • Condor menu starts
  • Start flight...
  • Steam VR STOPS running
  • everything renders in VR as previously described: Revive2 1 1 131_MSAA-on-or-off_VR-View Outside Revive2 1 1 131_MSAA-on-or-off_VR-View Cockpit

MSAA enabled in game:

  • Right click Revive tray icon
  • Inject Condor.exe...
  • Condor menu starts
  • Start flight...
  • Steam VR STOPS running
  • everything renders in VR as previously described: see 2.1.1.131 beta screenshots above

HTH. I'm off to pop 1.9.2 back on and have a quick fly :)

Gu7 avatar Feb 07 '21 20:02 Gu7

Would it be helpful to the Revive team to have a copy of & license for Condor 2 - i.e., if you had such a license, would you be willing to try to improve the situation for Condor 2 running under Revive?

cbrunschen avatar Nov 07 '22 12:11 cbrunschen

Just a quick update, I saw the same behavior (canopy, instruments and sky are black / opaque) with 3.0.

pvaiko avatar Jan 13 '23 18:01 pvaiko

Could you try out this build? https://ci.appveyor.com/project/LibreVR/revive/builds/46542962/artifacts

CrossVR avatar Mar 19 '23 00:03 CrossVR

I just tried the build linked in this comment, Injecting Revive into Condor 2, using Virtual Desktop to stream over WiFi to my Oculus Quest headset – and it all seemed to work, including with MSAA enabled (tried it at both 2x and 4x). Glider, sky, instruments, text overlays, all seemed to be displaying correctly. SteamVR also continued to run throughout.

cbrunschen avatar Mar 19 '23 09:03 cbrunschen

... and what I meant to add was of course a big thank you!

It might be worth posting this build for wider testing to the Condor forum's VR topic, to see how well it works for people with other headsets (HP Reverb G2 etc).

cbrunschen avatar Mar 19 '23 09:03 cbrunschen

This will eventually be part of the next release. Thanks for testing out the build, glad to see the new MSAA support in Revive is working correctly.

CrossVR avatar Mar 19 '23 11:03 CrossVR

That sounds great, thank you!

cbrunschen avatar Mar 19 '23 12:03 cbrunschen

I've tested this with Revive 3.2.0, and it seems to be working. I also posted on the Condor Forums and a reply there stated,

I have tested the new Revive 3,2,0 in my Pico neo 3 link and Valve Index HMD´s and used the MSAA 8X option in Condor 2, and works nicely (All graphics options to maximum). The Pico neo3 with a pc witn a Nvidia 1080ti and the Valve Index with a PC with a RTX 3090. Tried the AA scenery and ran smoothly in both PC´s.

cbrunschen avatar Mar 29 '23 14:03 cbrunschen

Thanks ever so much for picking this up @cbrunschen. My G2 appeared to die October 2022 (turned out to be just the v2 lead died) and to be frank, other sims have taken over from Condor 2 for me since I originally raised this.

Thanks @CrossVR for looking in to this and fixing.

I'm going to have to re-install Condor 2 again now and give it a spin with Revive 3.2 and the G2 aren't I? :D

Gu7 avatar Apr 13 '23 10:04 Gu7