feat: rewrite file list
Implement
- https://github.com/LibreSign/libresign/issues/3143
This:
Need to stay here too:
/backport to stable30
/backport to stable29
To think
to-do
- [x] Make possible delete PDF files and don't only delete the signature request
For now, the the delete feature only delete the signature request, only at LibreSing tables..
I thought in 2 possible ways to solve this but will be necessary to think what's the best:
- When confirm to delete a file, put a checkbox to say that want to delete the file too and not only the signature request.
- Put two delete options:
- Delete signature request
- Delete file. When delete file, will also delete the signature request.
PS: I prefer the option 1 more from the previous subject.
Going more deep into other points:
- Now, when upload a new file, the file only is added when you define the signer, but the file stay at Nextcloud side. I think that would be good to store at LibreSign side too as draft before to define the signers. With this change will make possible to see and delete a file that was uploaded by LibreSign side.
- [x] Save file reference in the database as a draft as soon as it is uploaded, before defining who will sign.
At LibreSign menu we have the action "Request". With this PR we also have the request inside action "Files" with the same options (upload new file, request from URL and choose from app Files). Maybe we can remove the action "Request" from main LibreSign menu because sounds as redundant.
My opinion: The "Request" at LibreSign menu sounds more clear and easy to identify how to upload a new file, but... we can implement a first run wizard explaining to an admin account about how to request to sign a file. Would be best to implement a "first run wizard" into a new PR do don't make too complex this PR.
To who see this PR:
A point that will make me and everyone involved in the development of LibreSign very happy is if we receive more recurring funding from LibreSign's GitHub Sponsor. This will greatly help to keep the project developing.
If you have any other ideas on how to help the project continue to improve, we would be happy to hear from you: [email protected]
I thought in 2 possible ways to solve this but will be necessary to think what's the best:
1. When confirm to delete a file, put a checkbox to say that want to delete the file too and not only the signature request. 2. Put two delete options: 1. Delete signature request 2. Delete file. When delete file, will also delete the signature request.
I agree that option 1 would be easier UX to most users, it is also very similar to how whatsapp handles "delete media" in chats
p.s. unfortunately i'm not in a position to able to do a donation