File filters do not work properly

[DazeEnd]

Describe the bug In LibreSign > Files, there are "All Files", "Pending", and "Signed" buttons that seem intended to filter the view and show only the indicated types of files. These buttons do not work the way I expect.

To Reproduce

1. After requesting signatures and receiving signatures on several files, open the LibreSign app, and then click "Files" in the sidebar.

2. Notice at three buttons appear at the top of this "Files" screen: "All Files", "Pending", and "Signed". By default, "All Files" is selected.

3. Click the "Pending" button and examine the files that are displayed.

4. Click the "Signed" button and examine the files that are displayed.

Expected behavior After clicking the "Pending" button in step 3, only files that are in the "available for signature" state should be displayed. After clicking the "Signed" button in step 4, only files that are in the "signed" state should be displayed.

Actual behavior After clicking the "Pending" button in step 3, all files are displayed whether or not they are signed. After clicking the "Signed" button in step 4, only files that that are in the "available for signature" state are displayed.

Screenshots

Environment information (please complete the following information):

• OS: AlmaLinux 8.9
• Browser: Chrome
• LibreSign Version: v8.0.0-rc6
• Nextcloud Server Version: v28.0.2
• Logs (get the entries from nextcloud.log related with LibreSign i.e tail -f data/nextcloud.log|grep libresign): No messages were printed to nextcloud.log as a result of these steps.

Additional context N/A

[DazeEnd]

This does NOT appear to be completely fixed in LibreSign v8.0.0-rc7 on Nextcloud 28.0.2. The "All Files" filter and "Pending" filter work correctly, but the "Signed" filter reports that "There are no documents" even though there is a signed document to display. (SELinux is disabled.)

[vitormattos]

Fixed by:

• #2569

[vitormattos]

@DazeEnd could you check the prints that I made at PR #2569 ?

Background

Looking the prints you will see two red status:

• Status: Draft. Is when we add a signer but don't send the file to be signed.
• Status: No signers. Is when we add a signer and after this, delete the signer.

Question

Do you think that both status need to be added as "pending" too?

[DazeEnd]

@vitormattos I like the way you divided it.

Display in Signed if status = "signed" Display in Pending if status = "available for signature" or status = "partially signed" Display everything in All, including status = "draft" and status = "no signers"

I agree with you that if no signature has been requested (as would be the case for status = "draft" and status = "no signers"), then it is not "Pending". "Pending" should be reserved for files that are waiting on action by somebody else.

[vitormattos]

Fixed at: https://github.com/LibreSign/libresign/releases/download/v8.0.0-rc9/libresign-v8.0.0-rc9.tar.gz

[DazeEnd]

This is fixed for me in v8.0.0-rc9.