red-moon icon indicating copy to clipboard operation
red-moon copied to clipboard

Optionally don't filter soft system navigation bar

Open smichel17 opened this issue 5 years ago • 1 comments

From email:

I would like to disable Red Moon on just the soft touch buttons at the bottom(back, home, multitasking). Is this possible?

This is definitely possible — we just need to change the size of the overlay. TODO:

  • Investigate:

    • [ ] What is the bar officially called? (so we can name the setting correctly). Temp: "system navbar"
    • [ ] Can we detect the presence of the system navbar?
    • [ ] How is the height of the system navbar determined?

    I believe we already have questions 2 and 3 answered, just need to confirm that navigationBarHeightPx is the bar in question.

  • [ ] Add a "Filter system navbar" setting to the main screen, at the bottom in the "no effect on some devices" category. If possible, hide this on devices without a soft navbar.

  • [ ] Modify screenHeight to reflect the new setting. We shouldn't need to modify the layout params since the overlay is already top aligned.

If someone wants to submit a pull request for this, here are all the relevant files:
ScreenManager.kt, FilterFragment.kt, Config.kt, donottranslate.xml, strings.xml.

smichel17 avatar Feb 13 '19 03:02 smichel17

PLEASE GIVE OPTION TO DIM FULL SCREEN!!

These bright shapes do prove to be a bit of a nuisance. I'd be happy to see dimming them as a settings option. By now, I've got geometric retina burn from trying to see past these three blazing control icons all the time.

I use several apps that cover the nav bar on my Moto E4. With Red Moon, though, the nav bar is never dimmed so far. To a point, it defeats the purpose not to allow the full screen to be dimmed! Please someone fix this?

codingWhatzThat avatar Mar 02 '19 04:03 codingWhatzThat