librephotos icon indicating copy to clipboard operation
librephotos copied to clipboard

Compose container renaming broken as described in docs

Open MWP opened this issue 1 year ago • 2 comments

📝 Description of issue:

When creating a new installation of librephotos using docker compose method, containers cannot be renamed as described in the official docs here: https://docs.librephotos.com/docs/installation/environment-variables

🔁 How can we reproduce it:

I've found two problems:

1 -- As per instructions, copy "librephotos.env" to ".env", edit ".env", rename containers, run "make rename", start setup of containers with "docker compose up -d". The containers are not renamed. The Makefile pulls the names from "librephotos.env", not the renamed and edited ".env" file. I fixed this by editing the Makefile to get the names from ".env".

2 -- After the containers have been renamed, librephoto proxy does not start as the hostnames are not as specified in "nginx.conf".

Please provide additional information:

  • 💻 Operating system: Debian 12
  • ⚙ Architecture (x86 or ARM): x86
  • 🔢 Librephotos version: as pulled by docker compose
  • 📸 Librephotos installation method (Docker, Kubernetes, .deb, etc.): docker
  • 📁 How is you picture library mounted (Local file system (Type), NFS, SMB, etc.): local
  • ☁ If you are virtualizing librephotos, Virtualization platform (Proxmox, Xen, HyperV, etc.): n/a

MWP avatar Jun 20 '23 05:06 MWP

To rename the containers while keeping the proxy working, you just have to edit the docker-compose.yml file and change the container_name values to whatever you want

MrLego8-9 avatar Jan 20 '24 16:01 MrLego8-9