librephotos icon indicating copy to clipboard operation
librephotos copied to clipboard

storybook for the front-end

Open polaroidkidd opened this issue 2 years ago • 5 comments

Describe the enhancement you'd like Add storybook the the development process.

Describe why this will benefit the LibrePhotos Changing inputs and behaviour of components can be done in an isolated environment while remaining sure that all consumers adhere to the components' api

Additional context N/A

polaroidkidd avatar Sep 09 '22 13:09 polaroidkidd

I like the idea to have a storybook. @polaroidkidd are you planning to pick this up anytime soon?

sickelap avatar Sep 16 '22 09:09 sickelap

anytime soon?

Might start giving it a go this weekend. I can start with a couple of components to serve as a template (or a "how-not-to-do-it" reference since I've never worked with storybook) and then others can contribute to the book. If we want to actively maintain it, then new components should always include a story-book, right?

polaroidkidd avatar Sep 16 '22 09:09 polaroidkidd

Yes, new components should contain a storybook so we have a clear example of how to use it. For me, it's difficult to see us adding a lot of new components right now. I guess at the beginning we would be refactoring existing ones.

sickelap avatar Sep 16 '22 09:09 sickelap

should we maybe add refactored components to the book too as part of the refactoring?

polaroidkidd avatar Sep 16 '22 09:09 polaroidkidd

sure. Just pick a component that is definitely used in multiple places, like Tile

sickelap avatar Sep 16 '22 09:09 sickelap