librephotos icon indicating copy to clipboard operation
librephotos copied to clipboard

Adding support for blurhash

Open savvasdalkitsis opened this issue 1 year ago • 3 comments

This PR is adding support for blurhash, a way to make the loading UI even prettier.

Please note that this PR is a draft because, honestly, I'm not a python expert and need help from the community to get this production ready and working (not to mention I had problems getting this to run locally so I couldn't even verify this works as intended 🤣, so please go easy on me)

This PR is paired with https://github.com/LibrePhotos/librephotos-frontend/pull/580 on the frontend

savvasdalkitsis avatar Nov 27 '24 19:11 savvasdalkitsis

Blurhash will be the successor to dominant color, which you correctly identified. We will probably then phase out dominant color within the next year. This will also act as a replacement to the small thumbnails in the future see https://github.com/LibrePhotos/librephotos/issues/812, which means that we will probably have to choose the regular thumbnail instead of the small one.

Otherwise, this looks good to me! :)

derneuere avatar Nov 28 '24 09:11 derneuere

Ah didn't know this was already in the works. And it does look like thumbhash is better than blurhash. will get that working hopefully for this PR

savvasdalkitsis avatar Nov 28 '24 20:11 savvasdalkitsis

A while back I outlined this feature but haven’t had the chance to implement it yet. I wanted to provide more context about how I see this feature integrating into the software. If you identify any benefits of using BlurHash in this context, please feel free to share your thoughts! :)

derneuere avatar Nov 28 '24 20:11 derneuere