librephotos icon indicating copy to clipboard operation
librephotos copied to clipboard

Replace pylint, black and isort with ruff

Open AnkurPrabhu opened this issue 1 year ago • 6 comments

Issue Link: #778 @derneuere what has been done :

  • edited .pre-commit-config.yaml file for adding ruff
  • edited pyproject.toml for the same

AnkurPrabhu avatar Oct 30 '23 06:10 AnkurPrabhu

It replaces isort, black and flake8. Ideally we should only have ruff at the end. You also need to remove isort, black and flake8 it and add ruff in requirements.dev.txt

derneuere avatar Oct 30 '23 12:10 derneuere

It replaces isort, black and flake8. Ideally we should only have ruff at the end. You also need to remove isort, black and flake8 it and add ruff in requirements.dev.txt

yes got it i just raised the pr to make sure i am in the right direction will add it in requirements.txt

AnkurPrabhu avatar Oct 30 '23 13:10 AnkurPrabhu

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 31 '23 20:10 sonarqubecloud[bot]

@derneuere so as far as i have researched the only thing i have not added is pylint. The code for pylint in .toml file is 'PL' once i add this it throws a lot of errors so didnt add it here ..so need some guidance here as in what should i do here.

AnkurPrabhu avatar Oct 31 '23 20:10 AnkurPrabhu

According to the documentation ruff provides pylint rules and acts as a replacement. Without a specific error message, I can't give you more guidance. I think you should probably just fix the error.

derneuere avatar Nov 01 '23 09:11 derneuere

According to the documentation ruff provides pylint rules and acts as a replacement. Without a specific error message, I can't give you more guidance. I think you should probably just fix the error.

okay will try to fix all the issues

AnkurPrabhu avatar Nov 23 '23 19:11 AnkurPrabhu