librephotos
librephotos copied to clipboard
Replace pylint, black and isort with ruff
Issue Link: #778 @derneuere what has been done :
- edited
.pre-commit-config.yaml
file for adding ruff - edited
pyproject.toml
for the same
It replaces isort, black and flake8. Ideally we should only have ruff at the end. You also need to remove isort, black and flake8 it and add ruff in requirements.dev.txt
It replaces isort, black and flake8. Ideally we should only have ruff at the end. You also need to remove isort, black and flake8 it and add ruff in requirements.dev.txt
yes got it i just raised the pr to make sure i am in the right direction will add it in requirements.txt
@derneuere
so as far as i have researched the only thing i have not added is pylint. The code for pylint in .toml
file is 'PL' once i add this it throws a lot of errors so didnt add it here ..so need some guidance here as in what should i do here.
According to the documentation ruff provides pylint rules and acts as a replacement. Without a specific error message, I can't give you more guidance. I think you should probably just fix the error.
According to the documentation ruff provides pylint rules and acts as a replacement. Without a specific error message, I can't give you more guidance. I think you should probably just fix the error.
okay will try to fix all the issues