librephotos-frontend icon indicating copy to clipboard operation
librephotos-frontend copied to clipboard

sort person edit people list by face count

Open jcalado opened this issue 1 year ago • 4 comments

Should fix #765.

Also added a cursor: pointer style to improve UX.

jcalado avatar May 08 '23 20:05 jcalado

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 08 '23 20:05 sonarqubecloud[bot]

I might have misread the original issue 🤦 This improves the ModalPersonEdit modal when tagging photos from the lightbox sidebar.

EDIT: I should stop typing now. It's the same component, so this improves it everywhere.

jcalado avatar May 08 '23 20:05 jcalado

Excellent! But still, I don't like the design where it's sorted by the number of faces a person has. I prefer it how it was before, sorted alphabetically. It would be better if there was a section in the settings to decide whether to sort it alphabetically or by the number of faces a person has.

Nerodacles avatar May 08 '23 22:05 Nerodacles

Please keep alphabetic order by default but add sorting by number of faces as additional capability ! ;-)

loulou91 avatar May 09 '23 05:05 loulou91