OpenPDF icon indicating copy to clipboard operation
OpenPDF copied to clipboard

Issue619: add support for rowspan

Open Brooklyn-0 opened this issue 2 years ago • 1 comments

Description of the new Feature/Bugfix

Describe here how you fixed the bug, or implemented the new feature. Digging into the endElement method of HTMLworker class, I find there is something wrong with IncCell, which only adds the support for colspan of tr. In this way, I add one line of code in constructor of IncCell to imitate the setting of colspan to enable rowspan.

Related Issue: #619

Expected Result:

Screen Shot 2022-04-26 at 9 17 04 PM

Wrong Result:

Screen Shot 2022-04-26 at 9 15 40 PM

Unit-Tests for the new Feature/Bugfix

  • [Y] Unit-Tests added to reproduce the bug

Compatibilities Issues

Is anything broken because of the new code? Any changes in method signatures? No, there is nothing broken because of the new code. No, there is no change in method signatures

Testing details

Any other details about how to test the new feature or bugfix? I reproduce the broken steps of nonsupport of rowspan.

Brooklyn-0 avatar May 29 '22 08:05 Brooklyn-0

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 29 '22 08:05 sonarqubecloud[bot]