OpenPDF icon indicating copy to clipboard operation
OpenPDF copied to clipboard

fix the .HEIC image bug #130

Open youyumeimei opened this issue 2 years ago • 6 comments

Description of the new Feature/Bugfix

Describe here how you fixed the bug, or implemented the new feature.

Related Issue: #130

Unit-Tests for the new Feature/Bugfix

  • [ ] Unit-Tests added to reproduce the bug
  • [ ] Unit-Tests added to the added feature

Compatibilities Issues

Is anything broken because of the new code? Any changes in method signatures? No.

Testing details

Any other details about how to test the new feature or bugfix? According to the issue, we write a test file. It can make pdf files and can see them to test whether it is successed.

youyumeimei avatar Apr 24 '22 17:04 youyumeimei

I'm reluctant to add this to OpenPDF. Since im4java is just a wrapper which uses the ImageMagick CLI, the user would need to have this tool on their path when they want to add a HEIC image. The additional dependencies are not actually needed if the user would transform their HEIC images to PNG in their own code. This would keep OpenPDF focused on what it does best.

mluppi avatar Apr 26 '22 19:04 mluppi

Hi @youyumeimei , can you take a look at the build errors of this PR? If this compiles I can merge it.

asturio avatar May 11 '22 21:05 asturio

Hello @asturio, Of course, I can. I will try my best to fix it.

youyumeimei avatar May 13 '22 15:05 youyumeimei

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 25 '22 11:05 sonarqubecloud[bot]

@youyumeimei The code is not compiling. Can you take a look at it?

asturio avatar May 27 '22 08:05 asturio

Is there any change this can be done without lombok and PDFBox?

asturio avatar Sep 15 '22 06:09 asturio

Please remove the dependency on Pdfbox.

andreasrosdal avatar Oct 18 '22 19:10 andreasrosdal