librepcb-doc
librepcb-doc copied to clipboard
Library manual
This adds a lot of useless files inside the Library_Manual directory (.editorconfig, .gitattributes, CONTRIBUTING.md, ...), could you please remove them? And could you maybe rebase the branch to master and get rid of the merge commit? IMHO it's very hard to understand the current commit history ;)
In addition, the new content will not appear in the hosted documentation since it is not included anywhere...
Done
On Sun, Dec 29, 2019 at 1:27 PM U. Bruhin [email protected] wrote:
This adds a lot of useless files inside the Library_Manual directory (.editorconfig, .gitattributes, CONTRIBUTING.md, ...), could you please remove them? And could you maybe rebase the branch to master and get rid of the merge commit? IMHO it's very hard to understand the current commit history ;)
In addition, the new content will not appear in the hosted documentation since it is not included anywhere...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibrePCB/librepcb-doc/pull/42?email_source=notifications&email_token=AAKX3XDEXLKON5L5M6UH243Q3EI5XA5CNFSM4JFSV7IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZIWWQ#issuecomment-569543514, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKX3XDL4M4FO5YGZTHMDQDQ3EI5XANCNFSM4JFSV7IA .
Done
Where? :grin: There was no push on this branch ;)
I show it in my LibrePCB repo under branch library_manual
On Mon, Jan 6, 2020 at 1:16 PM U. Bruhin [email protected] wrote:
Done
Where? 😁 There was no push on this branch ;)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibrePCB/librepcb-doc/pull/42?email_source=notifications&email_token=AAKX3XHGVNWHIJKGPEHXPYLQ4ONR7A5CNFSM4JFSV7IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIGZ5AI#issuecomment-571317889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKX3XB5RGCIZT6ESSFWWVTQ4ONR7ANCNFSM4JFSV7IA .
I show it in my LibrePCB repo under branch library_manual
The branch name for this PR is called Library_Manual, maybe that's the problem?