lh-ehr
lh-ehr copied to clipboard
LibreHealthIO
UI Improvements Discussion
unless some one knows a better choice my vote would be bootstrap.
Sent from my iPhone
On Jun 25, 2017, at 8:14 AM, Nilesh Prasad [email protected] wrote:
Should we start using Bootstrap or some other UI framework?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Yes, I have started working over UI. I'll be sending many pull requests, soon. I'll keep the pull requests smaller for UI. (page-by-page)
Bootstrap...tied in to the copy under /assets
Are you already moving Bootstrap ?
Yes, assets/js/ has three versions of bootstrap. Current, current RTL, and a really old version.
I will move Bootstrap 3.3.7 if you are not moving anything. And delete those old ones ..
I assume you mean that you will do a full GREP/SED to find everywhere they are called up and changing the versions...applying testing etc.. before the delete of the old ones, and make it all 3.3.7 if it all still functions. That is a good sized piece right there, (and there are lots of copies of bootstrap elsewhere, because developers are like teenage boys) but I suppose as the major library for everything you are doing, this does indeed fall into your bailiwick.
Be careful of the RTL version, that one is needed and may have customization.
Tony McCormick
On Jun 27, 2017 5:52 AM, "Art Eaton" [email protected] wrote:
I assume you mean that you will do a full GREP/SED to find everywhere they are called up and changing the versions...applying testing etc.. before the delete of the old ones, and make it all 3.3.7 if it all still functions. That is a good sized piece right there, (and there are lots of copies of bootstrap elsewhere, because developers are like teenage boys) but I suppose as the major library for everything you are doing, this does indeed fall into your bailiwick.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/LibreEHR/issues/597#issuecomment-311348547, or mute the thread https://github.com/notifications/unsubscribe-auth/AARci7yY_OZVtwLic85gLjJIBqGacYEVks5sIPsGgaJpZM4OEl17 .
-- Please be aware that e-mail communication can be intercepted in transmission or misdirected. Please consider communicating any sensitive information by telephone. The information contained in this message may be privileged and confidential. If you are NOT the intended recipient, please notify the sender immediately with a copy to [email protected] and destroy this message.
On changing themes, there are only changes in background color and button styles at some places. So, I think it would be better to give users an option to choose background color , instead of choosing themes. There can be a color picker for that purpose. I'll like to look over this. I'll also work on layout of tables and forms using Bootstrap grids and would try to make the frames as responsive as possible. The navbar at top can be completely redesigned. Can you all give more suggestions ?
When you work with the nav bar make sure you look at the pull request for the role based menus. If you could keep that and maybe expand on it that would be great. Remember on the layout forms if you remove a field the field is removed from the data base (would like for that to not happen).
Go get'em!!!
I like the color picker Idea . I thought the themes did more than color. I am pretty sure there are some changes with the size and other stuff, but if you can get it to one theme that would be super and give the ability to make color changes that would be cool. I am not sure if the RTL stuff has different theme's or not.
Yeah, I'll look over that pull.
Remember on the layout forms if you remove a field the field is removed from the data base (would like for that to not happen).
I'll mostly work on the layout of the forms and would not be removing any fields. If any field is required to be removed , I can do that if you all want.
No I don't know of any we need to remove, it is Just a word of caution when working there.
Here is the branch where I am upgrading UI :: https://github.com/nileshprasad137/LibreEHR/tree/improve-ui
As of now, you can check changes in UI in following sections::
-
Administration/Facilities -
Administration/Users -
Administration/Addr.Book(can be improved) -
Administration/Practice -
Administration/Code(can be improved) -
Administration/List -
Administration/Alerts
Please give suggestions when you see them..
@nileshprasad137 Can you check your code that was committed to the code base. The entry to /library/headers.inc.php has a couple of errors. I noticed this when I was working in the encounter screen. If you will check it , I was using the next and previous arrows to go back and forth in the encounters. Thanks
Are you talking about those console errors? I had added link to Bootstrap assets in headers.inc.php ..
I noticed one more major error when user opens a user page ::
This is showing some log errors because prescription classes were still trying to access the Smarty, which I had removed. I am working on this and will send a PR urgently.
I had not made changes in Prescription controller and templates, which is what was causing problem.Fixing it.
You have a fail to load error, the very first one. It is caused by the last line in headers.inc.php.
If you will notice you have bootsrap not bootstrap 8^)
Oops :sweat_smile: . Ok fixing that. And also removing smarty from Prescription classes as that is urgent!!
I think getting the js headers function up will help (make easier to solve) a LOT of issues we have posted for UI refactor...
Sorry for being a bit inactive lately. I had been busy with the placement related activities which happens during this time of the year in our college for hiring interns.
Back to full strength now. Will accelerate a bit and would get the next UI pull request soon.
Hey...I just spent all day with no internet. It was like 1984. Looking forward to the next cool-ray piece!
After updating UI in Administration/Practice..
Theme:metal
Theme -lightblue
Theme-purple
As you can see, the body of the iframe tab isnt getting affected by changing themes as I used bootstrap there. Should I proceed in this way, to restrict it to single theme and add a color-picker to have a bg-color for the rest of body(between frames and nav-bar)? Also, I have covered most of the sections in Administration section. But would like to keep Pull request smaller for the easier review. For now, I can send a PR for Administration/Practice .. Should I? Refer my branch here .
Also, I had kept a branch earlier in the discussion-->https://github.com/nileshprasad137/LibreEHR/tree/improve-ui .However this was with the old headers.
Yeah Nilesh, I think we may be simplifying the themes...real soon. In a drastic way.