Fix in Patient Issues Showing Incorrect Date When left Blank

[ahanipeitra1994]

This is a fix on issue #1555. The Patient 'Issues' now does not display incorrect date without entry.

[Ngai-E]

This is a fix in issue #1555. The Patient 'Issues' now does not display incorrect date without entry.

please can you send us a screenshot of the fix.

[ahanipeitra1994]

ok let me do that now

On Fri, 19 Jun 2020 at 09:24, Ngai Elizabeth [email protected] wrote:

This is a fix in issue #1555 https://github.com/LibreHealthIO/lh-ehr/issues/1555. The Patient 'Issues' now does not display incorrect date without entry.

please can you send us a screenshot of the fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1617#issuecomment-646509748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPC2ETOXDBH5J3AFB5DRXMODBANCNFSM4OCPY3NQ .

[ahanipeitra1994]

This is after the fix. The beginning and end date does not show again unless the field is entered.

On Fri, 19 Jun 2020 at 09:40, ahani peitra [email protected] wrote:

ok let me do that now

On Fri, 19 Jun 2020 at 09:24, Ngai Elizabeth [email protected] wrote:

This is a fix in issue #1555 https://github.com/LibreHealthIO/lh-ehr/issues/1555. The Patient 'Issues' now does not display incorrect date without entry.

please can you send us a screenshot of the fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1617#issuecomment-646509748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPC2ETOXDBH5J3AFB5DRXMODBANCNFSM4OCPY3NQ .

[ahanipeitra1994]

ok

On Fri, 26 Jun 2020 at 04:39, muarachmann [email protected] wrote:

@muarachmann requested changes on this pull request.

In interface/patient_file/summary/stats_full.php https://github.com/LibreHealthIO/lh-ehr/pull/1617#discussion_r445950888:

@@ -285,8 +285,8 @@ function newEncounter() {

 echo " <tr class='$bgclass detail' $colorstyle>\n";
 echo "  <td style='text-align:left' data-text='$disptitle' class='$click_class' id='$rowid'>" . text($disptitle) . "</td>\n";

• echo " " . text(date(DateFormatRead(true), strtotime($row['begdate']))) . " \n";
• echo " " . text(date(DateFormatRead(true), strtotime($row['enddate']))) . " \n";

• echo " " . text($row['begdate']) . " \n";
• echo " " . text($row['enddate']) . " \n";

This is not the right approach! Just check if the value is NULL or "" then show a default -, the functions there are not be removed

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1617#pullrequestreview-437993655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPBX4CGVPEWF76TIYATRYQJ63ANCNFSM4OCPY3NQ .

[ahanipeitra1994]

I will fix that

On Fri, 26 Jun 2020 at 08:21, ahani peitra [email protected] wrote:

ok

On Fri, 26 Jun 2020 at 04:39, muarachmann [email protected] wrote:

@muarachmann requested changes on this pull request.

In interface/patient_file/summary/stats_full.php https://github.com/LibreHealthIO/lh-ehr/pull/1617#discussion_r445950888 :

@@ -285,8 +285,8 @@ function newEncounter() {

 echo " <tr class='$bgclass detail' $colorstyle>\n";
 echo "  <td style='text-align:left' data-text='$disptitle' class='$click_class' id='$rowid'>" . text($disptitle) . "</td>\n";

• echo " " . text(date(DateFormatRead(true), strtotime($row['begdate']))) . " \n";
• echo " " . text(date(DateFormatRead(true), strtotime($row['enddate']))) . " \n";

• echo " " . text($row['begdate']) . " \n";
• echo " " . text($row['enddate']) . " \n";

This is not the right approach! Just check if the value is NULL or "" then show a default -, the functions there are not be removed

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1617#pullrequestreview-437993655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPBX4CGVPEWF76TIYATRYQJ63ANCNFSM4OCPY3NQ .

[ahanipeitra1994]

I tried the if/else statement but it was not functional then noticed the problem was caused by the "strtotime()" which outputs 1970 01 01 as date by default so thats y i changed it to a normal date

On Sat, 4 Jul 2020 at 01:55, muarachmann [email protected] wrote:

@muarachmann requested changes on this pull request.

In interface/patient_file/summary/stats_full.php https://github.com/LibreHealthIO/lh-ehr/pull/1617#discussion_r449725144:

@@ -285,8 +285,8 @@ function newEncounter() {

 echo " <tr class='$bgclass detail' $colorstyle>\n";
 echo "  <td style='text-align:left' data-text='$disptitle' class='$click_class' id='$rowid'>" . text($disptitle) . "</td>\n";

• echo " " . text($row['begdate']) . " \n";
• echo " " . text($row['enddate']) . " \n";

• echo " " . text(date(DateFormatRead(true), date($row['begdate']))) . " \n";
• echo " " . text(date(DateFormatRead(true), date($row['enddate']))) . " \n";

Yes we need some if/else statement here for blank dates

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1617#pullrequestreview-442578514, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPE6HIYDQG3WZ5KP25TRZZ4W7ANCNFSM4OCPY3NQ .

[maggienegm]

@ahanipeitra1994 it seems to still show the default timedate for me, even with date(). Can you push the if/else statements that you used? We can help guide you to a working solution if we can see the code.

[ahanipeitra1994]

ok i will do that