lh-ehr
lh-ehr copied to clipboard
LibreHealthIO
A fix In Message And Reminder Center Button
I fixed the message and reminder button and other buttons which has the same class.
Looks good so far! I just have a few small UI suggestions. The text within the buttons still seems off to me, like it's not fully centered. I would also change the text color to another color like white, so it's easier to see.
Ok I will arange it now on same branch
On Mon, 8 Jun 2020 at 19:45, Maggie Negm [email protected] wrote:
Looks good so far! I just have a few small UI suggestions. The text within the buttons still seems off to me, like it's not fully centered. I would also change the text color to another color like white, so it's easier to see.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/pull/1614#issuecomment-640804896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQABPHMZWHR3PWTPMSQEULRVUWTRANCNFSM4NWF7WDA .
@Ngai-E @muarachmann @robbyoconnor can I get one of you to review this? :)
Hmmm looks like I was too hasty when I left my review. Because the text was changed to white and button gif was removed, some buttons now look like this:
(Patient profile -> Issues)
Can you try to fix this?
@ahanipeitra1994 , tried to test this but I still have the default stuffs, also tried switching themes to no avail... maybe a good description will do
Woohoo! Most of the buttons are fixed! Great improvement!
Hmmm looks like I was too hasty when I left my review. Because the text was changed to white and button gif was removed, some buttons now look like this:
Can you try to fix this?
Looks like this issue still exists though. If you take a closer look, you'll notice those reference the "css_button" and "css_button_small" classes. I would start there :)