lh-ehr icon indicating copy to clipboard operation
lh-ehr copied to clipboard

White space/block present in the top right corner #1536

Open realJema opened this issue 4 years ago • 5 comments

Fix issue #1536

realJema avatar Mar 20 '20 18:03 realJema

@realJema , taking a look at this. Do you mind attaching a pic as to what your screen looks like with this solution?

maggienegm avatar Mar 26 '20 04:03 maggienegm

@realJema , taking a look at this. Do you mind attaching a pic as to what your screen looks like with this solution?

body background-color: green body_title background-color: transparent navbar-collapse background-color: transparent with fix Capture4

body background-color: green body_title background-color: blue navbar-collapse background-color: white without fix image

The previous fix just put everything with a background-color:white which is flawed in certain situations

realJema avatar Mar 28 '20 14:03 realJema

This does not count for GSoC @realjema

robbyoconnor avatar Apr 03 '20 19:04 robbyoconnor

@mhn94 could you review and close this. Thanks

realJema avatar Apr 16 '20 13:04 realJema

Hey @realJema . It seems like your fix isn't really targeting the issue at hand, which is to make the white block space blend in with the rest of the background color chosen.

Your fix removes the background colors (i.e. the primary and secondary color settings) of the elements aka making those areas of the screen transparent. transparent-UI

Rather than changing the background-color of those elements to "transparent," have you tried to see if the HTML element(s) in the white block is missing from that CSS statement block/ruleset?

maggienegm avatar Apr 18 '20 03:04 maggienegm